ad4630: handle spi_engine_ex_offload_load_msg() error

Add another error unwinding case and check the return value of the spi_engine_ex_offload_load_msg() function. This isn't currently being handled in ad4630_buffer_preenable(). Signed-off-by: Trevor Gamblin <[email protected]>
analogdevicesinc · Jan 10, 2025 · 95ff279 · 95ff279
1 parent 930e7a0
commit 95ff279
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/drivers/iio/adc/ad4630.c b/drivers/iio/adc/ad4630.c
@@ -735,7 +735,10 @@ static int ad4630_buffer_preenable(struct iio_dev *indio_dev)
 		goto out_reset_mode;
 
 	spi_bus_lock(st->spi->master);
-	spi_engine_ex_offload_load_msg(st->spi, &st->offload_msg);
+	ret = spi_engine_ex_offload_load_msg(st->spi, &st->offload_msg);
+	if (ret)
+		goto out_unoptimize;
+
 	spi_engine_ex_offload_enable(st->spi, true);
 
 	ret = pwm_set_waveform_might_sleep(st->conv_trigger, &st->conv_wf, false);
@@ -755,6 +758,7 @@ static int ad4630_buffer_preenable(struct iio_dev *indio_dev)
 out_offload_disable:
 	spi_engine_ex_offload_enable(st->spi, false);
 	spi_bus_unlock(st->spi->master);
+out_unoptimize:
 	spi_unoptimize_message(&st->offload_msg);
 out_reset_mode:
 	/* read this to reenter register configuration mode */