clang fixes #409
Merged
clang fixes #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of redefining the gtk structs, let's just forward declare. Otherwise clang was throwing this warning (treated as error): "error: redefinition of typedef 'GtkToggleToolButton' is a C11 feature [-Werror,-Wtypedef-redefinition]" Naturally we could just move to c11, but using the forward declaration still looks better. Signed-off-by: Nuno Sa <[email protected]>
Need to make sure all fall-through labels are annotated so that clang does not complain. A macro was added so that it looks better than using plain compiler __attributes__. Note that the macros is pretty direct which means there is no check to make sure the compiler has the proper attribute. Nowadays, it should not be an issue but if someone complains, we can then handle it at that time. Signed-off-by: Nuno Sa <[email protected]>
|
I also added an issue (#411) to don't forget about your suggestion. Thanks! |
pcercuei
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to compile with clang. Both of the "fixes" make sense.
It might make sense to have a CI job to also compile things with clang. Compiling with more than one compiler is always a good thing as it allow us to catch more things.