Time profile of sdk #642
Draft
Time profile of sdk #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
rbudai98
previously approved these changes
Apr 15, 2024
VHolonec
reviewed
Apr 15, 2024
| auto total_profiled_time = | ||
| compute_xyz_elapsed_time + sensor_get_frame_elapsed_time; | ||
|
|
||
| std::cout << "CameraItof::requestFrame() took: " |
There was a problem hiding this comment.
Why do you use std cout and not LOG(INFO) from glog?
There was a problem hiding this comment.
The main reason was to easily align the lines being printed. For example:
CameraItof::requestFrame() took: 80011us
|--> DepthSensorInterface::getFrame() took: 49724us(62.1465%)
|--> Algorithms::computeXYZ() took: 29566us(36.9524%)
Total profiled time: 79290us(99.0989%)
Another reason is that this way it's easier/clearer to separate the application usual logging from the printing of the time profiling. When one activates time profiling the most important thing to spot are the time measurements.
Also GLOG prints this header at the beginning of each line which is much noise in this situation.
Signed-off-by: Dan Nechita <[email protected]>
dNechita
force-pushed
the
time-profile-of-sdk
branch
from
2d053fb to
97d8530
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.