Use dedicated hardware and run existing smoke tests #30
+26
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpineda3
requested review from
ribdp,
SaikiranGudla,
jansunil and
CMinajigi
as code owners
ribdp
reviewed
Jun 4, 2024
JenkinsfileHW
Outdated
| @@ -42,15 +44,11 @@ lock(label: 'adgt_test_harness_boards') { | |||
| harness.set_send_telemetry(false) | |||
| harness.set_log_jira(false) | |||
| harness.set_enable_resource_queuing(true) | |||
| harness.set_lock_agent(true) // Required for MATLAB toolbox tests | |||
| harness.set_lock_agent(false) // Required for MATLAB toolbox tests | |||
There was a problem hiding this comment.
Out of curiosity, what is this change about? And do we need to update/remove the comment? Or do we indeed need the argument to be false for the MATLAB toolbox tests?
There was a problem hiding this comment.
The agent lock ensures that only one container is running at a time for MATLAB toolbox pipelines. This restriction was placed because of license errors when running MATLAB on multiple containers simultaneously. But now that the agents are using a network license, somehow the restriction is no longer necessary. I removed the comment but retained the setting.
Signed-off-by: Julia Pineda <[email protected]>
Signed-off-by: Julia Pineda <[email protected]>
ribdp
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixed issues with using dedicated Jenkins agent and can not run existing smoke tests on all three precision boards in test harness.
PR Type
PR Checklist