Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

Fix for aws-sdk-cpp log interface change - issue 44 #46

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

russnic
Copy link
Collaborator

@russnic russnic commented Apr 10, 2024

Issue #, if available:

Description of changes:

  • Updated with suggested fix from logged issue
  • Updated Github actions to build with the latest aws-sdk-cpp to confirm fix

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Updating github actions to fix CI issue

Adding sudo for ldconfig

Only run ldconfig on linux
@russnic russnic requested a review from smthsm April 10, 2024 13:56
@russnic russnic self-assigned this Apr 10, 2024
@russnic russnic requested review from johnbabat and josej4m April 10, 2024 14:25
@russnic russnic marked this pull request as ready for review April 10, 2024 14:25
Copy link
Collaborator

@smthsm smthsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josej4m
Copy link
Collaborator

josej4m commented Apr 10, 2024

Signing off the change

@russnic russnic merged commit b0887cf into master Apr 11, 2024
2 checks passed
@russnic russnic deleted the issue44 branch April 11, 2024 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants