This repository has been archived by the owner on Jan 8, 2025. It is now read-only.
Changes required fix build on Windows with MSVC #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, gstawscredentials-1.0.lib is not generated by LINK.exe because no symbols are exported, and compilation fails. We can simply use the symbols exported by gstreamer in gst/gstconfig.h to do this correctly. Related to amzn#13
Fixes this linker error: libmultipartuploader.a(gsts3multipartuploader.cpp.obj) : error LNK2001: unresolved external symbol "struct _GstDebugCategory * gst_s3_sink_debug" (?gst_s3_sink_debug@@3PEAU_GstDebugCategory@@ea) src/gsts3elements.dll : fatal error LNK1120: 1 unresolved externals Essentially, the debug category is a C symbol, so put it inside G_BEGIN_DECLS so that it doesn't get C++ symbol mangling.
This was referenced Jan 9, 2022
Closed
loganek
approved these changes
Jan 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR plus aws/aws-sdk-cpp#1839 fixes #13
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.