Added ability to use images, fixed warnings #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MaikoHermans Thanks! I will review it soon. |
|
@MaikoHermans Could you update the readme to include more information about your change and how to use it. |
amratab
reviewed
Sep 24, 2017
|
|
||
| } else { | ||
|
|
||
| startAngle = angle | ||
| endAngle = CGFloat(M_PI) | ||
| endAngle = CGFloat(Double.pi) | ||
|
|
||
| } |
There was a problem hiding this comment.
There is one more occurrence of M_PI in this file. Please replace it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now possible to add images to the views that have been passed already