Feat/text to .json chunks #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test project (framework also allows for reading pdf files directly) Signed-off-by: Florian Hoffmann <[email protected]>
Co-authored-by: FIlipe Borges <[email protected]> Co-authored-by: Florian Hoffmann <[email protected]>
Signed-off-by: Florian Hoffmann <[email protected]>
… moved pdfHandler to new module directory Signed-off-by: florian <[email protected]>
Signed-off-by: florian <[email protected]>
There was a problem hiding this comment.
Hey @get4flo . Just a code-style suggestion. Usually python files use snake_case naming convention. I would rename the module & file according to this.
graphCreator -> graph_creator
pdfHandler.py -> pdf_handler.py
Signed-off-by: florian <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implemented task of last week with Felipe. Created service to extract text from pdf file and turn into text chunks with metadata about chunk to pdf page mapping. Also added simple test to check functionality of the service.
*
Related Backlog Item
Issue: #4 , #17
Context
Checklist:
make formatto format my codeAdditional references