Search characters by level

[jkisor]

Search characters by level #211

Scope is limited to Character search by name and level.

The supported permutations:

• Search for characters by level
  • Example: "level:275"
• Search by name and level.
  • Example: "Asheron level:275"
• Search only name (existing behavior)
  • Example: "Asheron"

Notes:

• filter is identified as a word containing :; anything other words are assumed to be a name filter.
• Incomplete filters "level:" are discarded
• Fields must be whitelisted/allowed otherwise discarded; (current only allow "name" and "level")

Future considerations:

Special handling per field

As we allow more fields as filters, we need an approach to special handling different fields. For example, name needs regex case insensitive. A solution for this would lead to allowing different filters to have their own format/parsing (for example, supporting level ranges "level:15-25")

[jkisor]

Oops, we may have done the same work. No worries, Feel free to close.

[amoeba]

Hey @jkisor, apologies for the radio silence here. We did do similar work here, though I think there's some good stuff in yours. And mine could be improved for sure.

I'm going to close this PR mainly because of all the git-related noise. I've refactored how I do client message validation so this repo is no longer a mirror of a private repo and is instead the primary repo. I was using git-filter-branch for years which rewrites commits in order to filter out sensitive info and causes pain even when I was just working alone but even more pain when trying to take contributions.

Future contributions will likely be much easier to merge. Thanks for taking the time to contribute!