Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation matio 1 5 27 #82

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

S-Dafarra
Copy link
Member

@S-Dafarra S-Dafarra commented May 21, 2024

Fixes #81

@S-Dafarra S-Dafarra marked this pull request as ready for review May 21, 2024 17:01
@S-Dafarra S-Dafarra requested a review from traversaro May 21, 2024 17:01
@traversaro
Copy link
Collaborator

This works fine with older matio versions?

@S-Dafarra
Copy link
Member Author

This works fine with older matio versions?

I tested it on my machine where I did not update and seemed to work fine. I suppose it should be safe since now it is "more restrictive". Worst case I can use auto

@S-Dafarra S-Dafarra changed the title Fix compilation matio 1 5 17 Fix compilation matio 1 5 27 May 21, 2024
@S-Dafarra
Copy link
Member Author

S-Dafarra commented May 21, 2024

This works fine with older matio versions?

Actually the ci workflow tests it against the apt version which should be 1.5.21, while the conda version is 1.5.27

@traversaro
Copy link
Collaborator

This works fine with older matio versions?

Actually the ci workflow tests it against the apt version which should be 1.5.21, while the conda version is 1.5.27

Perfect!

1 similar comment
@traversaro
Copy link
Collaborator

This works fine with older matio versions?

Actually the ci workflow tests it against the apt version which should be 1.5.21, while the conda version is 1.5.27

Perfect!

@S-Dafarra
Copy link
Member Author

Thanks @traversaro

Merging

@S-Dafarra S-Dafarra merged commit 6a06e5c into master May 21, 2024
10 checks passed
@S-Dafarra S-Dafarra deleted the fix_compilation_matio_1_5_17 branch May 21, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation failure with matio 1.5.27
2 participants