Refactor gravity initialization and update post-init conversion to use default tensor type #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e default tensor type
|
I will close this PR for the time being. We can open it as soon as we start again with this activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the initialization of gravity parameters in two computation files and updates the default tensor type conversion in the
TorchLikeclass. The most important changes are:Initialization of gravity parameters:
src/adam/parametric/pytorch/computations_parametric.py: Simplified the initialization of thegravityparameter by removing the explicitdtypespecification.src/adam/pytorch/computations.py: Simplified the initialization of thegravityparameter by removing the explicitdtypespecification.Default tensor type conversion:
src/adam/pytorch/torch_like.py: Updated the__post_init__method in theTorchLikeclass to convert arrays to the default tensor type used in the library instead of always converting to double precision.📚 Documentation preview 📚: https://adam-docs--119.org.readthedocs.build/en/119/