Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add umq_version for npu.info #349

Merged
merged 3 commits into from
Jan 16, 2025
Merged

add umq_version for npu.info #349

merged 3 commits into from
Jan 16, 2025

Conversation

xdavidz
Copy link
Contributor

@xdavidz xdavidz commented Jan 13, 2025

@maxzhen this is needed for npu3 driver umq, but we have to get this in the core.

Signed-off-by: David Zhang <[email protected]>
@xdavidz xdavidz requested review from maxzhen and mamin506 January 13, 2025 04:27
Copy link
Contributor

@mamin506 mamin506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't put this "app.elf" and metadata in "firmwares" array. It doesn't look like other firmwares. Create a separate array.

@xdavidz
Copy link
Contributor Author

xdavidz commented Jan 13, 2025

Please don't put this "app.elf" and metadata in "firmwares" array. It doesn't look like other firmwares. Create a separate array.

If creating a separate array, would "umq_version" ok? or you prefer the name as "version"?

@mamin506
Copy link
Contributor

Please don't put this "app.elf" and metadata in "firmwares" array. It doesn't look like other firmwares. Create a separate array.

If creating a separate array, would "umq_version" ok? or you prefer the name as "version"?

umq_version is OK.

@mamin506 mamin506 merged commit f81b542 into amd:main Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants