Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🎨 corrected width of address feld #29

Closed
wants to merge 1 commit into from
Closed

fix: 🎨 corrected width of address feld #29

wants to merge 1 commit into from

Conversation

Perlenjaeger
Copy link

@Perlenjaeger Perlenjaeger commented Oct 16, 2024 •
edited
Loading

  • the width of the address feld is 85mm and set correctly but in the din 5008 the text of the address starts with an offset of 5mm. therfore the margin is set to 25 insted of 20. this results in to an width of 80 for the address feld insted of 85mm.
  • have a little offset for the folding marks of 2mm

fix: 🎨 corrected with of address feld
555b8c1 
- the with of the address feld is 85mm and set correctly but in the din 5008 the text of the address starts with an offset of 5mm. therfore the margin is set to 25 insted of 20. this results in to an with of 80 for the address feld insted of 85mm.
- have a little offset for the folding marks of 2mm
@Perlenjaeger Perlenjaeger changed the title fix: 🎨 corrected with of address feld fix: 🎨 corrected width of address feld Oct 16, 2024
@barredterra barredterra self-requested a review October 22, 2024 14:58
@barredterra barredterra self-assigned this Oct 22, 2024
barredterra
barredterra requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@barredterra barredterra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://upload.wikimedia.org/wikipedia/commons/0/00/DIN_5008_Form_B.svg, the address box starts 20mm from the left, is 85mm wide and has an inner padding of 5mm. This is exactly what the code does, without the changes from this PR. The padding does not increase the width of the element.

The changes to the folding marks are fine.

@Perlenjaeger
Copy link
Author

ja da hast du recht. war mein denkfehler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barredterra barredterra barredterra requested changes

Assignees

@Perlenjaeger Perlenjaeger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Perlenjaeger @barredterra