Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diag): Better error messages when trying to call a non-callable type #119

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

tibordp
Copy link
Member

@tibordp tibordp commented Oct 13, 2024

Fixes #118

The current error message when trying to call a non-callable object was pretty bad. This adds more information + adds a special case for possible field/method confusion.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.60%. Comparing base (304bf3f) to head (abebb2d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/alumina-boot/src/ir/mono/intrinsics.rs 0.00% 6 Missing ⚠️
src/alumina-boot/src/ir/mono/mod.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   88.62%   88.60%   -0.02%     
==========================================
  Files          35       35              
  Lines       17138    17144       +6     
==========================================
+ Hits        15188    15191       +3     
- Misses       1950     1953       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tibordp tibordp merged commit d37bba0 into master Oct 13, 2024
10 checks passed
@tibordp tibordp deleted the not-callable-diag-fix branch October 15, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diag: methods sharing names with struct fields produce confusing diagnostic message
1 participant