update readme version #195
clippy
27 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 27 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.83.0 (90b35a623 2024-11-26)
- cargo 1.83.0 (5ffbef321 2024-10-29)
- clippy 0.1.83 (90b35a6 2024-11-26)
Annotations
Check warning on line 548 in src/import_dats.rs
github-actions / clippy
useless use of `vec!`
warning: useless use of `vec!`
--> src/import_dats.rs:545:22
|
545 | &vec![
| ______________________^
546 | | game_xml.roms.iter().collect::<Vec<&RomXml>>(),
547 | | game_xml.disks.iter().collect::<Vec<&RomXml>>(),
548 | | ]
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
help: you can use an array directly
|
545 ~ &[game_xml.roms.iter().collect::<Vec<&RomXml>>(),
546 + game_xml.disks.iter().collect::<Vec<&RomXml>>()]
|
Check warning on line 425 in src/import_dats.rs
github-actions / clippy
useless use of `vec!`
warning: useless use of `vec!`
--> src/import_dats.rs:422:18
|
422 | &vec![
| __________________^
423 | | game_xml.roms.iter().collect::<Vec<&RomXml>>(),
424 | | game_xml.disks.iter().collect::<Vec<&RomXml>>(),
425 | | ]
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `#[warn(clippy::useless_vec)]` on by default
help: you can use an array directly
|
422 ~ &[game_xml.roms.iter().collect::<Vec<&RomXml>>(),
423 + game_xml.disks.iter().collect::<Vec<&RomXml>>()]
|
Check warning on line 70 in src/xdelta3.rs
github-actions / clippy
methods called `as_*` usually take `self` by reference or `self` by mutable reference
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/xdelta3.rs:70:18
|
70 | fn as_xdelta(self) -> SimpleResult<XdeltaRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
Check warning on line 184 in src/nsz.rs
github-actions / clippy
methods called `as_*` usually take `self` by reference or `self` by mutable reference
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/nsz.rs:184:15
|
184 | fn as_nsz(self) -> SimpleResult<NszRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
Check warning on line 163 in src/nsz.rs
github-actions / clippy
methods called `as_*` usually take `self` by reference or `self` by mutable reference
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/nsz.rs:163:15
|
163 | fn as_nsp(self) -> SimpleResult<NspRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
Check warning on line 175 in src/maxcso.rs
github-actions / clippy
methods called `as_*` usually take `self` by reference or `self` by mutable reference
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/maxcso.rs:175:21
|
175 | async fn as_xso(self) -> SimpleResult<XsoRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
Check warning on line 74 in src/flips.rs
github-actions / clippy
methods called `as_*` usually take `self` by reference or `self` by mutable reference
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/flips.rs:74:15
|
74 | fn as_xps(self) -> SimpleResult<XpsRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
Check warning on line 183 in src/dolphin.rs
github-actions / clippy
methods called `as_*` usually take `self` by reference or `self` by mutable reference
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/dolphin.rs:183:15
|
183 | fn as_rvz(self) -> SimpleResult<RvzRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
Check warning on line 131 in src/create_dats.rs
github-actions / clippy
this function has too many arguments (9/7)
warning: this function has too many arguments (9/7)
--> src/create_dats.rs:121:1
|
121 | / pub async fn create_dat<P: AsRef<Path>, Q: AsRef<Path>>(
122 | | connection: &mut SqliteConnection,
123 | | progress_bar: &ProgressBar,
124 | | input_directory: P,
... |
130 | | url: Option<&String>,
131 | | ) -> SimpleResult<()> {
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
Check warning on line 446 in src/common.rs
github-actions / clippy
methods called `as_*` usually take `self` by reference or `self` by mutable reference
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/common.rs:446:19
|
446 | fn as_cue_bin(self, bin_romfiles: Vec<CommonRomfile>) -> SimpleResult<CueBinRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
Check warning on line 409 in src/common.rs
github-actions / clippy
methods called `as_*` usually take `self` by reference or `self` by mutable reference
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/common.rs:409:15
|
409 | fn as_iso(self) -> SimpleResult<IsoRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
Check warning on line 548 in src/chdman.rs
github-actions / clippy
methods called `as_*` usually take `self` by reference or `self` by mutable reference
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/chdman.rs:548:33
|
548 | async fn as_chd_with_parent(self, parent_romfile: ChdRomfile) -> SimpleResult<ChdRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
Check warning on line 547 in src/chdman.rs
github-actions / clippy
methods called `as_*` usually take `self` by reference or `self` by mutable reference
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/chdman.rs:547:21
|
547 | async fn as_chd(self) -> SimpleResult<ChdRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
Check warning on line 112 in src/chdman.rs
github-actions / clippy
methods called `as_*` usually take `self` by reference or `self` by mutable reference
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/chdman.rs:112:22
|
112 | async fn as_rdsk(self) -> SimpleResult<RdskRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
Check warning on line 86 in src/chdman.rs
github-actions / clippy
methods called `as_*` usually take `self` by reference or `self` by mutable reference
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/chdman.rs:86:22
|
86 | async fn as_riff(self) -> SimpleResult<RiffRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
= note: `#[warn(clippy::wrong_self_convention)]` on by default
Check warning on line 70 in src/xdelta3.rs
github-actions / clippy
method `as_xdelta` is never used
warning: method `as_xdelta` is never used
--> src/xdelta3.rs:70:8
|
69 | pub trait AsXdelta {
| -------- method in this trait
70 | fn as_xdelta(self) -> SimpleResult<XdeltaRomfile>;
| ^^^^^^^^^
Check warning on line 19 in src/wit.rs
github-actions / clippy
field `romfile` is never read
warning: field `romfile` is never read
--> src/wit.rs:19:5
|
18 | pub struct WbfsRomfile {
| ----------- field in this struct
19 | romfile: CommonRomfile,
| ^^^^^^^
Check warning on line 35 in src/util.rs
github-actions / clippy
function `open_file` is never used
warning: function `open_file` is never used
--> src/util.rs:35:14
|
35 | pub async fn open_file<P: AsRef<Path>>(path: &P) -> SimpleResult<File> {
| ^^^^^^^^^
Check warning on line 279 in src/model.rs
github-actions / clippy
field `regions_hashes` is never read
warning: field `regions_hashes` is never read
--> src/model.rs:279:9
|
271 | pub struct Irdfile {
| ------- field in this struct
...
279 | pub regions_hashes: Vec<String>,
| ^^^^^^^^^^^^^^
Check warning on line 74 in src/flips.rs
github-actions / clippy
method `as_xps` is never used
warning: method `as_xps` is never used
--> src/flips.rs:74:8
|
73 | pub trait AsXps {
| ----- method in this trait
74 | fn as_xps(self) -> SimpleResult<XpsRomfile>;
| ^^^^^^
Check warning on line 22 in src/flips.rs
github-actions / clippy
field `xps_type` is never read
warning: field `xps_type` is never read
--> src/flips.rs:22:9
|
20 | pub struct XpsRomfile {
| ---------- field in this struct
21 | pub romfile: CommonRomfile,
22 | pub xps_type: XpsType,
| ^^^^^^^^
Check warning on line 2409 in src/database.rs
github-actions / clippy
function `update_patch` is never used
warning: function `update_patch` is never used
--> src/database.rs:2409:14
|
2409 | pub async fn update_patch(
| ^^^^^^^^^^^^
Check warning on line 1238 in src/database.rs
github-actions / clippy
function `find_roms_with_romfile_by_system_id` is never used
warning: function `find_roms_with_romfile_by_system_id` is never used
--> src/database.rs:1238:14
|
1238 | pub async fn find_roms_with_romfile_by_system_id(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 1097 in src/database.rs
github-actions / clippy
function `find_roms` is never used
warning: function `find_roms` is never used
--> src/database.rs:1097:14
|
1097 | pub async fn find_roms(connection: &mut SqliteConnection) -> Vec<Rom> {
| ^^^^^^^^^
Check warning on line 679 in src/database.rs
github-actions / clippy
function `find_games` is never used
warning: function `find_games` is never used
--> src/database.rs:679:14
|
679 | pub async fn find_games(connection: &mut SqliteConnection) -> Vec<Game> {
| ^^^^^^^^^^