-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a flag for disabling tests for time-compat #110
base: master
Are you sure you want to change the base?
Conversation
Have you tried the workaround suggested by @Tritlo in haskell/time#136 (comment)? |
No, I haven't. I actually didn't see that comment (I did implement this fix in back March, only now decided to make it into MR). |
Yeah, that seems to work, installing cachix required some changes in system configuration though which is annoying. Not sure if that was NixOS specific. |
I am also trying to use I've tried building both normally and with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Hithroc ,
Thanks a lot for this PR! Unfortunately, I'm not using Windows, so it's hard for me to judge if this really fixes a or the problem...
Maybe, someone using WSL2 could be so kind to test this?
@@ -22,6 +22,7 @@ in | |||
, withNuma ? nixpkgs.stdenv.isLinux | |||
, withDtrace ? nixpkgs.stdenv.isLinux | |||
, withGrind ? true | |||
, fixWSL2 ? false # fix time-compat build issues for WSL2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make sense to set the default according to the environment?
Like withDtrace ? nixpkgs.stdenv.isLinux
, but for WSL2 if that is possible? 🤔
Hey @AlexKnauth ,
So, does this PR solve the issue on your machine? (I'm a bit unsure about how to interpret the word normally.) Your input would be very valuable, as I don't have access to any Windows machine... |
How should I supply the new |
WSL2 has an annoying bug where
clock_getres
returns a resolution of 1ns, but the actual clock resolution is 100ns. microsoft/WSL#6029 haskell/time#136Because of this, building time-compat results in a failure:
This PR adds
fixWSL2
flag that disablestime-compat
tests. I'm pretty sure overridingtime-compat
like this means that package caches can't be used anymore and all of the dependencies will have to be recompiled, so this flag is disabled by default. Annoying, but better than not building at all!