-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split dev packages #171
Split dev packages #171
Conversation
c57dbda
to
e023836
Compare
e023836
to
b7de017
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just left a question.
.github/workflows/build.yaml
Outdated
matrix: | ||
env: | ||
- ALPINE_VERSION=3.17 ROS_DISTRO=noetic ROS_DISTRIBUTION_TYPE=ros1 | ||
- ALPINE_VERSION=3.17 ROS_DISTRO=humble ROS_DISTRIBUTION_TYPE=ros2 | ||
- ALPINE_VERSION=3.20 ROS_DISTRO=noetic ROS_DISTRIBUTION_TYPE=ros1 | ||
- ALPINE_VERSION=3.20 ROS_DISTRO=noetic ROS_DISTRIBUTION_TYPE=ros1 SPLIT_DEV=yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we keep both alpine 3.20 noetic jobs or was it just for development?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our Alpine ROS repository will split dev packages, but users still can keep them not splitted when building their packages using ros-abuild-docker image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ros-abuild:3.20-noetic
image is pushed twice but I guess it is not a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna revert the matrix and test split-dev mode in each matrixed job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our Alpine ROS repository will split dev packages, but users still can keep them not splitted when building their packages using ros-abuild-docker image
I noticed this is wrong.
As ros-noetic-catkin
doesn't contain dev files on v3.20, catkin packages on v3.20 must be always built by split-dev mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed to test only split-dev mode on v3.20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated docker image to automatically enable split-dev mode on 3.20
Automatically split dev dependencies and files to
-dev
subpackage.All dev packages will be automatically installed if ros-dev meta package is installed.
We can install ros-dev to the base image by default to keep the default behavior.
Users can install packages without dev files by
apk add !ros-dev ...
Dependencies
On master branch,
ros-noetic-rospack
had following depsWith
--split-dev
option,ros-noetic-rospack
hasand
ros-noetic-rospack-dev
hasWith
--split-dev
option, ROS packages inbuild_depends
will be resolved asros-noetic-package
+ros-noetic-package-dev
in APKBUILD.Files
For example,
ros-noetic-rostime
will containand
ros-noetic-rostime-dev
will contain