Upgrade mocha to v3.0.0.pre.rc.1 #9846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pezholio @ryanb-gds @Harriethw @andysellick @georges1996 I'm sorry to bother you - I've tagged you because you have recent commits in this repo. Is there any chance you could put this upgrade of Mocha to v3.0.0.pre.rc.1 through your CI pipeline and let me know if you run into any problems so I can fix them before the official release of v3.0.0. Thank you! |
|
@pezholio Thank you! ❤️ |
|
Seems to work well - looking forward to the official release! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be great if you could run this change through your CI pipeline and let me know if you run into any problems so I can fix them before the official release of v3.0.0. Thank you!
I suggest you don't merge this PR, but hold off until the official release.