Revert changes in 94.0 to remove old phone number validation code with fix to emergency contact issue #1184
+147
−223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparke
force-pushed
the
remove-old-phonenumber-validation
branch
2 times, most recently
from
942c223 to
b6b0965
Compare
…nenumbers validate method on CSVs A fix is ready for admin that will allow CSVs for emergency contact lists in S3 to send, even if they contain an invalid row, to prevent the whole contact list from failing to send. This does not impact new CSVs which will all be validated properly
rparke
force-pushed
the
remove-old-phonenumber-validation
branch
from
b6b0965 to
df074b6
Compare
rparke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a fix pending for admin for the emergency contact list issue. This removes the old validation code again and adds a flag
should_validate_phone_numberwhich lets us toggle validation on/off for CSVs so that we can validate new uploads but be more relaxed when trying to send from old emergency contact lists in S3 that may contain invalid numbers.