Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rails from 7.2.2.1 to 8.0.1 #1052

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 6, 2025

Bumps rails from 7.2.2.1 to 8.0.1.

Release notes

Sourced from rails's releases.

8.0.1

Active Support

  • Fix a bug in ERB::Util.tokenize that causes incorrect tokenization when ERB tags are preceeded by multibyte characters.

    Martin Emde

  • Restore the ability to decorate methods generated by class_attribute.

    It always has been complicated to use Module#prepend or an alias method chain to decorate methods defined by class_attribute, but became even harder in 8.0.

    This capability is now supported for both reader and writer methods.

    Jean Boussier

Active Model

  • No changes.

Active Record

  • Fix removing foreign keys with :restrict action for MySQ

    fatkodima

  • Fix a race condition in ActiveRecord::Base#method_missing when lazily defining attributes.

    If multiple thread were concurrently triggering attribute definition on the same model, it could result in a NoMethodError being raised.

    Jean Boussier

  • Fix MySQL default functions getting dropped when changing a column's nullability.

    Bastian Bartmann

  • Fix add_unique_constraint/add_check_constraint/add_foreign_key to be revertible when given invalid options.

    fatkodima

  • Fix asynchronous destroying of polymorphic belongs_to associations.

    fatkodima

  • Fix insert_all to not update existing records.

    fatkodima

... (truncated)

Commits
  • cf6ff17 Preparing for 8.0.1 release
  • 0bba3c2 Merge pull request #53936 from jsharpify/jsharpify/prism-parsing
  • 8521b99 [RF-DOCS] Update Rails Testing Guide [ci skip] (#53872)
  • dbe61a7 Merge pull request #53907 from p8/guides/fix-canonical
  • f8d559d [RF-DOCS] Asset Pipeline Documentation (Propshaft) [ci-skip] (#53875)
  • 2ae1d69 [RF-DOCS] Solid Cache updates in Caching with Rails: An Overview [ci-skip] (...
  • 85bde83 Merge pull request #53926 from Ridhwana/Ridhwana/solid-queue
  • c167cbe Merge pull request #53941 from byroot/rack-server-protocol
  • 656e209 Merge pull request #53940 from mjankowski/rdoc-link-to-add-check-constraint
  • b9608a6 Merge pull request #53937 from fatkodima/mysql-fix-remove-foreign-key-restrict
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@dependabot dependabot bot force-pushed the dependabot/bundler/rails-8.0.1 branch from c13b3b6 to e71b51f Compare January 6, 2025 08:38
@brucebolt
Copy link
Member

Covered by this Trello card.

@brucebolt brucebolt marked this pull request as draft January 6, 2025 09:26
@dependabot dependabot bot force-pushed the dependabot/bundler/rails-8.0.1 branch 3 times, most recently from 48802fd to 07275b4 Compare January 20, 2025 08:42
@dependabot dependabot bot force-pushed the dependabot/bundler/rails-8.0.1 branch from 07275b4 to f69f98d Compare January 22, 2025 08:41
Bumps [rails](https://github.com/rails/rails) from 7.2.2.1 to 8.0.1.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v7.2.2.1...v8.0.1)

---
updated-dependencies:
- dependency-name: rails
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/rails-8.0.1 branch from f69f98d to 9004059 Compare January 29, 2025 13:14
@callumknights callumknights force-pushed the dependabot/bundler/rails-8.0.1 branch from 0266ab4 to 4f9c248 Compare January 29, 2025 18:36
@callumknights callumknights marked this pull request as ready for review January 29, 2025 18:38
Copy link
Contributor

@mike3985 mike3985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested a couple of changes, other than that this all makes sense to me 👍

config/environments/production.rb Show resolved Hide resolved
config/environments/production.rb Show resolved Hide resolved
Skipped puma config since we use GovukPuma, and force_ssl options
@callumknights callumknights force-pushed the dependabot/bundler/rails-8.0.1 branch from 4f9c248 to 1db4058 Compare February 5, 2025 09:48
@callumknights callumknights merged commit da25b66 into main Feb 5, 2025
8 checks passed
@callumknights callumknights deleted the dependabot/bundler/rails-8.0.1 branch February 5, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants