WIP Add global banner handling #34
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KludgeKML
force-pushed
the
global-banner
branch
from
ca5b4ff to
7737e38
Compare
- Since we'll want to add in validation for the global banner, update the validator to rely on a shared base class, and make a method of the rake output. - Add a colour to the rescue case when reading the config file fails.
- Here we just need to add one route, but two ways to get into it so that we can prove it doesn't render the banner on the same page the banner is pointing at.
- currently WIP because the form of the global banner component in the publishing components app hasn't been finalised.
- Like recruitments banners, we have a validator, a test suite that makes sure the validator works, and a validator run during the default rake task.
KludgeKML
force-pushed
the
global-banner
branch
from
7737e38 to
2dce6c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/RqkCbWDD/394-add-global-banner-handling-to-govukwebbanners