Skip to content

Commit

Permalink
Refactor asset-manager clamav labels
Browse files Browse the repository at this point in the history
Description:
- Currently `clamav-pvc` will match onto any `PersistentVolume` with `app.kubernetes.io/instance: asset-manager` as this is contained in `asset-manager.selectorLabels`. However if another `PersistentVolume` were to be deployed with `asset-manager.selectorLabels` there is a chance it will match onto that rather than `clamav-pv` which is the wrong result
- Ensure it only matches on labels that end in `-clamav-db` preventing this mixup
- As part of #1883
  • Loading branch information
nimalank7 committed Jan 27, 2025
1 parent 76e3fbc commit 78485ea
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion charts/asset-manager/templates/clamav-pvc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@ spec:
storage: {{ .Values.nfs.clamAvStorage }}
selector:
matchLabels:
{{- include "asset-manager.selectorLabels" . | nindent 6 }}
app.kubernetes.io/name: {{ $fullName }}-clamav-db
app.kubernetes.io/component: {{ $fullName }}-clamav-db

0 comments on commit 78485ea

Please sign in to comment.