Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a depends_on email-alert-api to content-data #713

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add a depends_on email-alert-api to content-data
content-data-admin now depends on email-alert-api to retrieve metrics about the
number of email subscriptions.
peteglondon committed Jan 10, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 6b2ef720a06296bc4d6fe0fb7a6819ddd66fce1a
2 changes: 1 addition & 1 deletion projects/content-data-admin/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
content-data-admin: bundle-content-data-admin content-data-api
content-data-admin: bundle-content-data-admin content-data-api email-alert-api
$(GOVUK_DOCKER) run $@-lite bin/rake db:prepare
$(GOVUK_DOCKER) run $@-lite env RAILS_ENV=test bin/rake db:prepare
$(GOVUK_DOCKER) run $@-lite yarn
1 change: 1 addition & 0 deletions projects/content-data-admin/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -32,6 +32,7 @@ services:
<<: *content-data-admin
depends_on:
- content-data-api-app
- email-alert-api-app
- nginx-proxy
- postgres-13
expose: