Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change option on devolved nations component #3508

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

andysellick
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Update instances of the devolved nations component to use a different option name. The option has changed from 'type' to 'content_type'.

Note that this PR will probably fail tests until the change to the component is included in this PR.

Why

The option is changing in alphagov/govuk_publishing_components#4535

Visual changes

None.

Trello card: https://trello.com/c/hUDC8lzz/418-add-component-wrapper-helper-to-button-component

- option has changed from 'type' to 'content_type'
Copy link
Contributor

@AshGDS AshGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing test passes locally for me with the latest verison of the gem 👍

Should this have [DO NOT MERGE] until the gem is released?

@andysellick andysellick changed the title Change option on devolved nations component [DO NOT MERGE] Change option on devolved nations component Jan 9, 2025
- to version that includes this change
@andysellick andysellick changed the title [DO NOT MERGE] Change option on devolved nations component Change option on devolved nations component Jan 13, 2025
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3508 January 13, 2025 11:52 Inactive
@andysellick andysellick merged commit a91838a into main Jan 13, 2025
11 checks passed
@andysellick andysellick deleted the change-devolved-option branch January 13, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants