Stop using mobile_top_margin with heading component #3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
changed the title
andysellick
force-pushed
the
reconfigure-headings
branch
from
93dc46a to
8949526
Compare
andysellick
force-pushed
the
reconfigure-headings
branch
from
8949526 to
254ddba
Compare
- previously using the responsive margin bottom mixin, but this doesn't provide enough spacing on consultation pages - instead switch to using the component wrapper helper, which includes an option to set margin bottom - set margin bottom to match existing (on desktop, better on mobile)
- headings have this unusual behaviour where the mobile top margin is much larger - this is slightly odd and inconsistent behaviour, so we're removing this option from the heading component and applying custom spacing in these pages instead using existing component options
- headings have this unusual behaviour where the mobile top margin is much larger - this is slightly odd and inconsistent behaviour, so we're removing this option from the heading component and applying custom spacing in these pages instead using existing component options
- headings have this unusual behaviour where the mobile top margin is much larger - this is slightly odd and inconsistent behaviour, so we're removing this option from the heading component and applying custom spacing in these pages instead using existing component options
andysellick
force-pushed
the
reconfigure-headings
branch
from
254ddba to
c96d79f
Compare
andysellick
changed the title
AshGDS
approved these changes
Jan 7, 2025
| component_helper.set_lang("en") | ||
| component_helper.add_data_attribute({ module: "ga4-link-tracker" }) | ||
| component_helper.add_data_attribute({ ga4_track_links_only: "" }) | ||
| component_helper.add_data_attribute({ ga4_link: { event_name: "navigation", type: "callout" } }) |
There was a problem hiding this comment.
Nitpick: is it worth combining the data attribute statements? No worries if you think it's more readable separated.
There was a problem hiding this comment.
Fair question, but yeah, I think it's probably more readable like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change how we use the heading component margin options in consultations pages.
Why
We're removing this option from the heading component because there's some very specific behaviour on these pages and we should move away from corner cases like this to a spacing model that works across pages.
Relates to alphagov/govuk_publishing_components#4510
Visual changes
Some minor spacing changes.
Consultations pages headings have slightly smaller spacing below on desktop and above on mobile.
Call for evidence pages headings have a similar change.
Publications are similar, although I'm not sure of an example of a publication page.
Trello card: https://trello.com/c/l4VyD7Nm/395-retire-page-title-component