Use Time.zone.parse instead of Date.parse in ManualUpdatesPresenter #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgisbey
changed the title
davidgisbey
force-pushed
the
use-time-zone-parse-for-parsing-updated-at-time-for-manuals
branch
from
1ff602c to
8a48a3e
Compare
davidgisbey
force-pushed
the
use-time-zone-parse-for-parsing-updated-at-time-for-manuals
branch
from
8a48a3e to
16f898a
Compare
davidgisbey
force-pushed
the
use-time-zone-parse-for-parsing-updated-at-time-for-manuals
branch
from
16f898a to
f30ef1c
Compare
At the moment, it uses Date.parse which doesn't account for the difference in timing between the timestamp (UTC) and local time (BST). This causes issues with some updates being a day off if they were published between 00.00 & 00.59. Time.zone.parse parses the date correctly into the "London" timezone. We still need to convert it back into a date though as it groups on year, then by identical dates, so all updates for a day are grouped.
davidgisbey
force-pushed
the
use-time-zone-parse-for-parsing-updated-at-time-for-manuals
branch
from
f30ef1c to
ca02d69
Compare
ryanb-gds
approved these changes
Oct 18, 2023
davidgisbey
deleted the
use-time-zone-parse-for-parsing-updated-at-time-for-manuals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment, it uses Date.parse which doesn't account for the difference in timing between the timestamp (UTC) and local time (BST).
This causes issues with some updates being a day off if they were published between 00.00 & 00.59.
Time.zone.parse parses the date correctly into the "London" timezone. We still need to convert it back into a date though as it groups on year, then by identical dates, so all updates for a day are grouped.
Screenshots
Before
After
Trello card
https://trello.com/c/idVD4RQT/1794-update-history-shows-the-wrong-date
Follow these steps if you are doing a Rails upgrade.