Skip to content

Commit

Permalink
Merge pull request #2965 from alphagov/ab-test-video-killed-the-utr-star
Browse files Browse the repository at this point in the history
Remove underscores from AB test name
  • Loading branch information
richardTowers authored Oct 20, 2023
2 parents 457c2c1 + 6c378ee commit 0dfde1e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion app/controllers/content_items_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ def temporary_ab_test_find_utr_page
placeholder = "{{ab_test_find_utr_number_video_links}}"
if @content_item.base_path == "/find-utr-number" && @content_item.body.include?(placeholder)
ab_test = GovukAbTesting::AbTest.new(
"find_utr_number_video_links",
"FindUtrNumberVideoLinks",
dimension: 61, # https://docs.google.com/spreadsheets/d/1h4vGXzIbhOWwUzourPLIc8WM-iU1b6WYOVDOZxmU1Uo/edit#gid=254065189&range=69:69
allowed_variants: %w[A B Z],
control_variant: "Z",
Expand Down
6 changes: 3 additions & 3 deletions test/controllers/content_items_controller_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ class ContentItemsControllerTest < ActionController::TestCase

stub_content_store_has_item(content_item["base_path"], content_item)

request.headers["HTTP_GOVUK_ABTEST_FIND_UTR_NUMBER_VIDEO_LINKS"] = nil
request.headers["HTTP_GOVUK_ABTEST_FINDUTRNUMBERVIDEOLINKS"] = nil

get :show, params: { path: path_for(content_item) }
assert_response :success
Expand All @@ -386,7 +386,7 @@ class ContentItemsControllerTest < ActionController::TestCase

stub_content_store_has_item(content_item["base_path"], content_item)

request.headers["HTTP_GOVUK_ABTEST_FIND_UTR_NUMBER_VIDEO_LINKS"] = "A"
request.headers["HTTP_GOVUK_ABTEST_FINDUTRNUMBERVIDEOLINKS"] = "A"

get :show, params: { path: path_for(content_item) }
assert_response :success
Expand All @@ -401,7 +401,7 @@ class ContentItemsControllerTest < ActionController::TestCase

stub_content_store_has_item(content_item["base_path"], content_item)

request.headers["HTTP_GOVUK_ABTEST_FIND_UTR_NUMBER_VIDEO_LINKS"] = "B"
request.headers["HTTP_GOVUK_ABTEST_FINDUTRNUMBERVIDEOLINKS"] = "B"

get :show, params: { path: path_for(content_item) }
assert_response :success
Expand Down

0 comments on commit 0dfde1e

Please sign in to comment.