Add file type validation #1154
Open
Add file type validation #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBiddle
force-pushed
the
add-file-type-validation
branch
2 times, most recently
from
e9e587f to
6d57689
Compare
Adds validation to check that the uploaded file has one of the expected MIME types.
Adds the ['accept' attribute](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file#accept) to the file upload input. This doesn't prevent the user from uploading other file types, but it provides hints to their operating system on what kind of files we accept, so it reduces the chances of a user uploading a disallowed file type accidentally. Uses the same list of allowed filetypes as the backend validation, so they should stay in sync.
In the file upload feature test, we were using a TempFile. This failed after the file type validation was added, because the TempFile returns a of which trips the validation. This commit replaces the TempFile with a real, empty text file, which is created in the folder and deleted after the test completes. This should make the test closer to real use of the feature.
DavidBiddle
force-pushed
the
add-file-type-validation
branch
from
6d57689 to
d5b995f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/Nr7OQkk2/2092-limit-the-file-types-that-can-be-uploaded
Adds:
acceptattribute on the file input with the same MIME types above. This will provide hints to the user's operating system on what kinds of files they should choose.Testing instructions
If you want to bypass the
acceptattribute on a Mac in order to test the backend validation, you can:Screenshots
When selecting a file, you should see hints about allowed files - in Finder on a Mac it looks like this:
After submitting a file of the wrong type, you should see this error message:
Things to consider when reviewing