feat: add request-response #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Lint / proto (pull_request).
|
Velnbur
requested changes
Jan 13, 2025
| } => { | ||
| if response.msg.is_empty() { | ||
| debug!(%request_id, "Have no needed data, requesting from neighbours"); | ||
| return Ok(()); // TODO(NikitaMasych): launch recursive request. |
There was a problem hiding this comment.
I think the node should request this data again after some time instead, so we may have TimeoutManager to be an event-loop, reactor kind of thing instead of a place for timeouts only. But let's consider this in next PR
Velnbur
reviewed
Jan 13, 2025
Velnbur
approved these changes
Jan 13, 2025
storopoli
pushed a commit
that referenced
this pull request
Jan 28, 2025
* feat: basic swarm * Make swarm and database constructable from outside of P2P type (#9) This is needed for P2P users to specify `memory` or `tcp` transport and whether the database should be temporarly, for tests and production accordingly. Co-authored-by: Velnbur <[email protected]> * Move db and protobuf related code to separate crates (#8) Move `crates/p2p/src/db` to `crates/db`, `crates/p2p/src/wire` to `crates/wire` and then `crates/wire/proto/` out of `wire` to top level `proto`. Also some minor refactor stuff and fixes to make CI happy were applied. * chore: fix ci (#11) * chore: moved nextest config to .config/ * chore: add github token to arduino/setup-protoc * Move `tokio`, `tokio-util` and `tracing-subscriber` to workspace deps (#10) * feat: Add new methods for tests, make `init` public and add test (#12) `init` was renamed to `establish_connections` and made public, so the crate user can control stages of P2P readiness. Added test with sequential handling of multiple scopes with multiple operators. * Add doc comments to some of the methods and remove redundant code (#13) * feat: add request-response (#14) * feat: added basic request-response * feat: added pub key storage in db entry and signature validation * fix: review issues resolved * fix: refactor pubkey serde + remove all_messages_empty * Add async threadpooled wrapper for `sled::Db` (#16) * refactor: operator id not via peer id (#15) * refactor: operator id now independent of peer id * fix: post-review improvements * chore: taplo fmt * fix: resolve end-to-end tests * chore: cargo fmt --all * chore: taplo fmt * chore: remove unused deps in cargo.toml files * draft: added whitelist of signers * fix: resolve issues * refactor: move validation into p2p * fix: resolve some review comments * fix: resolve db test private field * refactor: migrated from snafu to thiserror (#17) * refactor: migrated from snafu to thiserror * refactor: post-review improvements * refactor: post-review improvements * fix(db): agnostic InvalidData error * fix * Remove `TimeoutManager` and add command for requesting messages for `P2PHandle` (#18) * Remove timeout manager To simplify current code for Testnet I, as state handling of peers is not in the scope for now. * Add implementation of direct `RequestMessage` command for handles By removing timeouts handling in the previous commit, we didn't left an option for P2P users to request something through `request-response` behaviour. That's why this commit adds handling of `Command::RequestMessage`. Added persistent mapping of operator pubkey to peer id, that distributed messages from this operators, so P2P can request that message directly by retrieving peer ID from this mapping. * Make threadpool for DB with one core for tests instead of all * refactor: request command use fallback neighbours request (#20) * refactor: added request from neighbours in request command * wip: added request-response test * fix: resolved test * refactor: upd tests * trying to fix compiler bug * fix visibility in tests * refactor: renamed OperatorLever * refactor: moved handling of request-response message to separate function * refactor: Use `SessionId` instead of `Scope` for nonces and signatures exchange messages (#19) * Introduce `SessionId` and `Scope` types * Replace hash with scope, refactor names * Add `CleanStorage` command for P2P (#21) `CleanStorageCommand` - deletes all entries from storage by session IDs, scopes and operators' pubkeys. For that `delete_raw` method for `Repository` was added, which deletes entries at once by array of keys. Implementation creates cartesian products from sets of operators' pubkeys and session IDs, operators' pubkeys and scopes, then deletes all some entries at once, but sequantially for each type of entry (nonces, signatures or deposit setups). --------- Co-authored-by: Velnbur <[email protected]> Co-authored-by: Kyrylo Baibula <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add request-response protocol.
Type of Change
Notes to Reviewers
Basic, untested version.
Checklist
Related Issues