Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use separate tags for P2WPKH and P2WSH #40

Closed
wants to merge 5 commits into from

Conversation

storopoli
Copy link
Member

@storopoli storopoli commented Jan 13, 2025

Description

Updates the spec to use exclusive type tags for all BOSD types.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Closes #27.

@storopoli storopoli changed the title fix: update borsh feat: use separate tags for P2WPKH and P2WSH Jan 13, 2025
@storopoli storopoli requested a review from delbonis January 13, 2025 12:48
@storopoli storopoli closed this Jan 13, 2025
@storopoli
Copy link
Member Author

Closing in favor of #43.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use separate type tag for P2WPKH and P2WSH payloads
1 participant