Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make length constants public #34

Merged
merged 1 commit into from
Jan 12, 2025
Merged

fix: make length constants public #34

merged 1 commit into from
Jan 12, 2025

Conversation

storopoli
Copy link
Member

Description

make the pub(crate) constant lengths public, i.e. pub.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

@storopoli storopoli mentioned this pull request Jan 12, 2025
13 tasks
@storopoli storopoli self-assigned this Jan 12, 2025
@storopoli storopoli force-pushed the storopoli/pub-const branch from 9daf240 to cc52cd8 Compare January 12, 2025 19:52
Copy link
Contributor

@AaronFeickert AaronFeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@storopoli storopoli merged commit d2eb1cb into main Jan 12, 2025
10 checks passed
@storopoli storopoli deleted the storopoli/pub-const branch January 12, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants