bashi-validate: remove required parameter #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed required parameter because the filter works different compare to the original implementation from alpaka-job-matrix-library, where the implementation is coming from. Now the ordering of the parameters in a row is not fixed anymore. The filter rules also checks only for two parameter at the same time an tries to cancel an invalid combination early as possible.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 95.69% 96.40% +0.70%
==========================================
Files 10 10
Lines 395 389 -6
Branches 99 99
==========================================
- Hits 378 375 -3
+ Misses 10 7 -3
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed required parameter because the filter works different compare to the original implementation from
alpaka-job-matrix-library, where the implementation is coming from. Now the ordering of the parameters in a row is not fixed anymore. The filter rules also checks only for two parameter at the same time an tries to cancel an invalid combination early as possible.