feat: DateTimeOffset #546
Open
feat: DateTimeOffset #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliedeman
commented
Sep 9, 2024
| try { | ||
| int longsRead = Decode(source, longs.AsSpan(0, data.Length)); | ||
| if(tse.LogicalType?.TIMESTAMP is not null) { | ||
| if(!tse.LogicalType.TIMESTAMP.IsAdjustedToUTC) { |
There was a problem hiding this comment.
This probably deserved a dedicated error and a link to the docs if this change is accepted
cliedeman
force-pushed
the
feat/datetimeoffset
branch
2 times, most recently
from
1d3e666 to
d1c16cc
Compare
cliedeman
force-pushed
the
feat/datetimeoffset
branch
from
d1c16cc to
3f4f8a6
Compare
cliedeman
commented
Sep 20, 2024
| /// </summary> | ||
| /// <param name="other"></param> | ||
| /// <returns></returns> | ||
| protected virtual bool BaseClrTypeCompatible(DataField other) => this.BaseClrType == other.BaseClrType; |
There was a problem hiding this comment.
This is a hack to fix the serialization append issue I encountered.
Fundamentally the parquet thrift schema on its own does not enough information to differentiate date time offset vs date time with the class.
Will have to rethink my approach. Possibly merge DateTimeOffsetDataField into DateTimeDataField somehow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my follow up to #521
Rationale:
I have many models that currently use DateTimeOffset to map entities and I would like to serialize these without creating mapping models.
I am aware that DateTimeOffset was previously removed due to confusion but I have added additional checks to try and mitigate this.
The Logical Timestamp helps with this as we can refuse to decode a Timestamp to DateTimeOffset when it is not in UTC. As this invites errors and can cause confusion. (DateTime avoids this by allowing you to stipulate the kind as
Local).