Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dependencies #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

fishme
Copy link
Contributor

@fishme fishme commented Jan 8, 2022

updated to latest react version and some other dependencies - so far possible.
Please test it also, with node 16.13.1 & npm 8.1.2 it was working well.

I'm not sure why you use rollup with babel for build and not webpack only. could be a reduction of dependencies.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

"react-dom": ">15.6.1",
"lodash": "^4.17.20",
"jquery": ">3.5.1"
"react": "~17.0.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can not change here.Many user use react15 & 16 . here support react 17.x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. well this was the idea of the PR to go to latest react version. then reject it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants