Refactor Code For new Plugin System #30
Open
+3,973
−3,225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh0g
force-pushed
the
refacto_for_plugin
branch
from
e543882 to
86f6919
Compare
almarouk
reviewed
Oct 28, 2024
| @@ -0,0 +1,45 @@ | |||
| [ | |||
| { | |||
There was a problem hiding this comment.
Formatting issue: a tab '\t' is used as indentation before the first element, whereas spaces are used in the rest of the document.
Fix suggestion: replace the tab with spaces to preserve consistency.
almarouk
reviewed
Oct 28, 2024
| { | ||
| "pluginName":"Utils", | ||
| "nodesFolder":"mrrs/utils" | ||
| } |
There was a problem hiding this comment.
Add space for indentation to be conform with the preceding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted meshroom research for new plugin system in alicevision/Meshroom#2407
TODOs: