-
-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SURF and BRISK feature types #702
base: develop
Are you sure you want to change the base?
Conversation
@leviresende let us know when it's ready for testing and review. |
@fabiencastan for sure! I'm facing some troubles, as soon as possible I'll give you a feedback |
Any news @leviresende ? How much faster are to calculate these types? Can you provide a side to side comparison with the current features? |
Hi!
The last time that I worked with that it was in October when I asked for
some help from Fabien. As nobody said nothing, I've changed my priorities.
So, in my case, time doesn't matter. What really matters is the number of
features match. I was working in dark environments, using artificial
lights. Bellow, you can see the results of my analysis.
[image: image.png]
To built this result, I was working with python and OpenCV, when I just
realized that this implementing also could help Alice and my
photogrammetries.
Best regards,
Levi Resende
…On Tue, Feb 4, 2020 at 6:15 AM Riccardo Giorato ***@***.***> wrote:
Any news @leviresende <https://github.com/leviresende> ? How much faster
are to calculate these types? Can you provide a side to side comparison
with the current features?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#702?email_source=notifications&email_token=AK4WCANRUQZCBHZUP7ENY73RBEW2HA5CNFSM4I7ZDBEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKW4DYI#issuecomment-581812705>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK4WCAMOUJCDW7KARKFVIJ3RBEW2HANCNFSM4I7ZDBEA>
.
|
@leviresende : We get a lot of questions and it's difficult to keep track of all the discussions. It's better to keep the maximum of them on github where we have the history, etc. I'm sorry if I missed to answer to you! |
As we've chatted before, the issue that I had was to compile the Meshroom. Give me a couple of days, I'll change my strategy to do this task. Whether I have any problem I'll post here, but please, be available. |
@leviresende Sorry if I missed to answer to an email, it was not intentional! |
If you need help, feel free to ask. I tried to finalize this PR myself, using this 01f9d52 as guideline, but I must have missed something as it did not work, so your continuation would be much appreciated. |
Thank @leviresende for working on this. |
Description
Add implementation of new feature types: SURF and BRISK.
Features list
Implementation remarks
Integration of algorithms implemented in OpenCV.