Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add estimator states to sfmdata #1607

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Add estimator states to sfmdata #1607

merged 4 commits into from
Dec 12, 2023

Conversation

servantftechnicolor
Copy link
Contributor

Goal :

  • cleanup
  • Be able to provide multiple policies in an easier way

LocalBundleAdjustment was storing the state of the sfmData properties (constant, ignored, refined) as a set of map.

Here we just move this information in the sfmData distributed in the various structures.

I kept the original structure and duplicate the information for the moment to keep the test working. It will need an update when the new classes will be used.

Copy link
Contributor

@cbentejac cbentejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me. I renamed the EParameterState enum into EEstimatorParameterState since the link with the BA is not obvious anymore from the name alone and clang'ed the modified files.

@cbentejac cbentejac merged commit 245daca into develop Dec 12, 2023
4 checks passed
@cbentejac cbentejac deleted the dev/temporaryLocks branch December 12, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants