Support ScatterOp Codegen #1270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eedalong
force-pushed
the
support_scatter
branch
4 times, most recently
from
0664a4e to
91d3a3f
Compare
Yancey1989
force-pushed
the
support_scatter
branch
from
91d3a3f to
520e5a9
Compare
eedalong
changed the title
Yancey1989
force-pushed
the
support_scatter
branch
2 times, most recently
from
3505b6d to
72b23e5
Compare
Yancey1989
force-pushed
the
support_scatter
branch
8 times, most recently
from
e0fad5d to
6e778a0
Compare
Yancey1989
force-pushed
the
support_scatter
branch
2 times, most recently
from
a83f009 to
dadfe54
Compare
Yancey1989
force-pushed
the
support_scatter
branch
4 times, most recently
from
b8b5e2a to
422fc9a
Compare
Yancey1989
reviewed
Dec 4, 2023
| auto sliceOpResultType = RankedTensorType::get(indexType.getShape(), srcType.getElementType()); | ||
| src = rewriter.create<mhlo::RealDynamicSliceOp>(loc, getTypeConverter()->convertType(sliceOpResultType), src, baseIndicesValue, limitIndicesValue, stridesValue); | ||
|
|
||
| // Construct ScatterDimensionNumbersAttr |
There was a problem hiding this comment.
duplicate comments with L1595 ?
|
|
||
| // Reference implementation: https://github.com/pytorch/xla/blob/master/torch_xla/csrc/xla_lower_util.cpp#L139 | ||
| template <> | ||
| LogicalResult ConvertAtenOp<AtenScatterSrcOp>::matchAndRewrite( |
There was a problem hiding this comment.
this rewriter function is too long, can you add some pesucode to describe how to lower the AtenScatterOp briefly?
| @@ -295,5 +295,26 @@ def LHLO_ArgsMutationOp : LHLODISC_Op<"args_mutation", []> { | |||
| ); | |||
| } | |||
|
|
|||
| def LHLODISC_InplaceScatterOp: LHLODISC_Op<"inplace_scatter", []> { | |||
There was a problem hiding this comment.
do we need a new operator to define a INPLACE op? Maybe we simple way is if (op.operand[0] == op.operand[-1]) ?
There was a problem hiding this comment.
Yeah you are right. Fixed.
| output_placements = "cpu", | ||
| outputs = "output0" | ||
| }} { | ||
| %2 = "mhlo.scatter"(%arg0, %arg1, %arg2) ({ |
There was a problem hiding this comment.
this ut is too simple, please check the IR of scatter op lowing.
Yancey1989
force-pushed
the
support_scatter
branch
3 times, most recently
from
c7c9589 to
d1eece4
Compare
Yancey1989
force-pushed
the
support_scatter
branch
2 times, most recently
from
bb5c6e6 to
799b5b7
Compare
Yancey1989
force-pushed
the
support_scatter
branch
from
799b5b7 to
002f0bd
Compare
Yancey1989
force-pushed
the
support_scatter
branch
from
002f0bd to
20cb101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.