Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: back adjust x&y while overlay is oversized #26

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

YSMJ1994
Copy link
Collaborator

@YSMJ1994 YSMJ1994 commented Nov 27, 2023

  1. 添加基于 x y 调整的兜底逻辑:

    1. overlay尺寸大于滚动视口尺寸情况,根据rtl设置,强制对齐习惯侧边缘

    2. 不大于情况,哪边超出,哪边重置为边缘位置

  2. 调整时,参考容器改为viewport

  3. pass autoHideScrollOverflow

Copy link

@eternalsky eternalsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YSMJ1994 YSMJ1994 merged commit 0bec448 into master Nov 29, 2023
4 checks passed
@YSMJ1994 YSMJ1994 deleted the fix/oversize-overlay-adjust branch November 29, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants