-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor adjust implementation #22
Conversation
需要使用 viewport 作为视口怎么理解?viewport 不就是视口吗 |
viewport指浏览器的可视区域,视口是指overlay元素参考的可视区域,可能会是它的滚动容器 |
这样解释感觉歧义太多了,viewport 翻译过来就是视口。不能这两个词中英文指代还不一样。浏览器视口就叫浏览器视口好了,overlay 里也有 getVIewPort 去拿真正的视口逻辑。 |
更新了一下 |
问题 2 我理解原 issue 应该不是觉得 align 的表现不正确吧,而是 align 之后,箭头的位置不对,我理解这是因为没有合适的 align 位置,所以挑选了一个 fallback 的位置导致的,原 issue 应该是希望能够动态调整箭头的位置,貌似和本 pr 的思路不太一致。 |
11a79bc
to
80818b0
Compare
@eternalsky 调整了一下getViewPort的实现,并添加了测试用例 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close alibaba-fusion/next#4137
改动点: