Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/overlay bubble box positioning and arrow alignment #18

Closed
wants to merge 12 commits into from

Conversation

YunMeng99
Copy link

No description provided.

@YunMeng99 YunMeng99 linked an issue Nov 6, 2023 that may be closed by this pull request
@YSMJ1994 YSMJ1994 requested a review from eternalsky November 7, 2023 03:38
@eternalsky
Copy link

@YunMeng99 pr 的标题要好好写。不要糊弄。

@YSMJ1994 YSMJ1994 requested review from YSMJ1994 and removed request for eternalsky November 8, 2023 02:25
@YunMeng99 YunMeng99 changed the title Fix/overlay style Fix/overlay Bubble Box positioning and Arrow alignment Nov 8, 2023
@YunMeng99 YunMeng99 changed the title Fix/overlay Bubble Box positioning and Arrow alignment Fix/overlay bubble box positioning and arrow alignment Nov 8, 2023
@YSMJ1994
Copy link
Collaborator

YSMJ1994 commented Nov 8, 2023

  1. 定位逻辑调整需要补充注释
  2. 代码没有格式化
  3. 用户的第二个问题没有解决 [Balloon]气泡框定位和箭头对齐问题 next#4137

@YunMeng99
Copy link
Author

  1. 定位逻辑调整需要补充注释
  2. 代码没有格式化
  3. 用户的第二个问题没有解决 [Balloon]气泡框定位和箭头对齐问题 next#4137

用户的第二个问题我试过了没问题呀

@YSMJ1994
Copy link
Collaborator

YSMJ1994 commented Nov 8, 2023

  1. 定位逻辑调整需要补充注释
  2. 代码没有格式化
  3. 用户的第二个问题没有解决 [Balloon]气泡框定位和箭头对齐问题 next#4137

用户的第二个问题我试过了没问题呀

搞错了,是第一个问题,非followTigger的情况下,箭头位置不对

@YSMJ1994
Copy link
Collaborator

YSMJ1994 commented Nov 8, 2023

@YunMeng99 @eternalsky 这个问题比较复杂,接下来我来跟进吧,定位这块的逻辑需要整体回头看一下

@YunMeng99
Copy link
Author

@YunMeng99 @eternalsky 这个问题比较复杂,接下来我来跟进吧,定位这块的逻辑需要整体回头看一下

好的

@YSMJ1994 YSMJ1994 closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Balloon]气泡框定位和箭头对齐问题
3 participants