fix: support asset transfers for decimal values over the safe number value #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neilcampbell
commented
Jan 23, 2025
neilcampbell
commented
- Support decimal asset transfer values over the limits of number
- Refine asJson to convert to number where applicable
- Fix zod bigInt schema usage
PatrickDinh
approved these changes
Jan 23, 2025
| } | ||
|
|
||
| const defaultJsonValueReplacer = (_key: string, value: unknown) => { | ||
| if (typeof value === 'bigint') { |
There was a problem hiding this comment.
I'm not so sure about bigint can be serialised to either string or number ... I think I prefer it to be always string.
There was a problem hiding this comment.
The main thing I like about this is the json view looks better using numbers. I thought about the scenario you mentioned with arrays, which I agree is strange, however I think it's unlikely to be a problem in our scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.