Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Heartbeat transaction #376

Merged
merged 7 commits into from
Jan 20, 2025
Merged

Added Heartbeat transaction #376

merged 7 commits into from
Jan 20, 2025

Conversation

lempira
Copy link
Contributor

@lempira lempira commented Jan 16, 2025

I am PRing @neilcampbell spike on adding heartbeat txn type. There were some TODO HB but it looks like they have been defined. I am guessing it's just a matter of getting the approval from product @larkiny

@lempira
Copy link
Contributor Author

lempira commented Jan 16, 2025

The preview apps don't seem to be deploying (looking into that). Was going to link the preview app, but I took a screenshot. How does does this look to you @larkiny ?

image image

@lempira
Copy link
Contributor Author

lempira commented Jan 17, 2025

I realized the color for the heartbeat txn was the same as keyreg. I choose a green color for heartbeat since green is alive.

image image

Copy link

cloudflare-workers-and-pages bot commented Jan 19, 2025

Deploying algokit-lora with  Cloudflare Pages  Cloudflare Pages

Latest commit: 64c8239
Status: ✅  Deploy successful!
Preview URL: https://65c34c4f.algokit-lora.pages.dev
Branch Preview URL: https://heartbeat-spike.algokit-lora.pages.dev

View logs

@lempira
Copy link
Contributor Author

lempira commented Jan 19, 2025

Ok, the third time is the charm. I got the current color in Lora and checked with @larkiny, and decided on a brighter yellow.

Current color in Lora

image

dark

image

light

image

@lempira lempira merged commit 4df9b84 into main Jan 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants