-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network select to network config table #329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying algokit-lora with Cloudflare Pages
|
lempira
force-pushed
the
new-network-select
branch
from
November 8, 2024 15:00
6515f0b
to
01311a9
Compare
lempira
force-pushed
the
new-network-select
branch
2 times, most recently
from
November 21, 2024 21:00
0ed1c2c
to
d98e403
Compare
lempira
commented
Nov 21, 2024
lempira
force-pushed
the
new-network-select
branch
from
November 25, 2024 00:02
29589ec
to
d821cc6
Compare
lempira
force-pushed
the
new-network-select
branch
from
November 25, 2024 18:55
6eb882d
to
dd39a5f
Compare
neilcampbell
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several items in this PR that were requested internally. The requests were the following:
The app before remembered the saved network and had some redirects so that when you went to settings, selected a network and clicked the back btn, you go back to the previous page but with the new selected network. This made the behavior of selecting the network from the header not work as it assumed it could only be done in settings. Now, the same workflow (i.e. hitting the back button) takes you to the network that was selected before. If you want to change the network from the settings page, you should then click on a page like Explore in order to take you to that network's explore.
If you are on a page that has some resource (asset, txn, application etc) that is not on that network, I added a custom error message to the error page that would ask the users if they were on the correct network and a link that would take them to the main feature page with that network selected.
Kapture.2024-11-21.at.15.40.59.mp4
New Settings Page
Error Page with 404