Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network select to network config table #329

Merged
merged 12 commits into from
Nov 27, 2024
Merged

Add network select to network config table #329

merged 12 commits into from
Nov 27, 2024

Conversation

lempira
Copy link
Contributor

@lempira lempira commented Nov 8, 2024

There were several items in this PR that were requested internally. The requests were the following:

  • The main request was to be able to select a network through a drop-down in app header instead of going through the settings page only
  • The second was to be able to "activate" the network in the settings page from the table instead of the drop-down.

The app before remembered the saved network and had some redirects so that when you went to settings, selected a network and clicked the back btn, you go back to the previous page but with the new selected network. This made the behavior of selecting the network from the header not work as it assumed it could only be done in settings. Now, the same workflow (i.e. hitting the back button) takes you to the network that was selected before. If you want to change the network from the settings page, you should then click on a page like Explore in order to take you to that network's explore.
If you are on a page that has some resource (asset, txn, application etc) that is not on that network, I added a custom error message to the error page that would ask the users if they were on the correct network and a link that would take them to the main feature page with that network selected.

Kapture.2024-11-21.at.15.40.59.mp4

New Settings Page
image

Error Page with 404
image

Copy link

cloudflare-workers-and-pages bot commented Nov 8, 2024

Deploying algokit-lora with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4529bf0
Status: ✅  Deploy successful!
Preview URL: https://0054ad92.algokit-lora.pages.dev
Branch Preview URL: https://new-network-select.algokit-lora.pages.dev

View logs

@lempira lempira force-pushed the new-network-select branch from 6515f0b to 01311a9 Compare November 8, 2024 15:00
@lempira lempira changed the title test for preview Add network select to network config table Nov 8, 2024
@lempira lempira force-pushed the new-network-select branch 2 times, most recently from 0ed1c2c to d98e403 Compare November 21, 2024 21:00
@lempira lempira marked this pull request as ready for review November 21, 2024 21:19
@lempira lempira requested a review from neilcampbell November 21, 2024 21:19
src/App.routes.tsx Outdated Show resolved Hide resolved
src/features/accounts/pages/account-page.tsx Outdated Show resolved Hide resolved
src/features/common/pages/error-page.tsx Outdated Show resolved Hide resolved
src/features/layout/components/header.tsx Outdated Show resolved Hide resolved
src/features/network/pages/network-page.tsx Show resolved Hide resolved
src/features/network/components/network-configs-table.tsx Outdated Show resolved Hide resolved
@lempira lempira merged commit 306e10c into main Nov 27, 2024
2 checks passed
@lempira lempira deleted the new-network-select branch January 16, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants