Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor some assertions to common code #24

Merged
merged 7 commits into from
Apr 22, 2024
Merged

chore: refactor some assertions to common code #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b1d9163
chore: refactor some assertions to common code
PatrickDinh Apr 22, 2024
2b517e8
chore: PR feedback
PatrickDinh Apr 22, 2024
dcdf5aa
chore: refactor the tests
PatrickDinh Apr 22, 2024
3b4c4b6
Merge remote-tracking branch 'origin/main' into test-refactor
PatrickDinh Apr 22, 2024
f897af6
lint
PatrickDinh Apr 22, 2024
0a786a2
chore: refactor the tests
PatrickDinh Apr 22, 2024
f0c73ef
chore: done I hope
PatrickDinh Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 51 additions & 28 deletions src/features/blocks/pages/block-page.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,15 @@ import { HttpError } from '@/tests/errors'
import { blockResultMother } from '@/tests/object-mother/block-result'
import { createStore } from 'jotai'
import { blocksAtom } from '../data'
import { getByDescriptionTerm } from '@/tests/custom-queries/get-description'
import { nextRoundLabel, previousRoundLabel, roundLabel, timestampLabel, transactionsLabel } from '../components/block'
import { transactionsAtom } from '@/features/transactions/data'
import { transactionResultMother } from '@/tests/object-mother/transaction-result'
import { assetResultMother } from '@/tests/object-mother/asset-result'
import { assetsAtom } from '@/features/assets/data'
import { ellipseId } from '@/utils/ellipse-id'
import { ellipseAddress } from '@/utils/ellipse-address'
import { tableAssertion } from '@/tests/assertions/table-assertion'
import { descriptionListAssertion } from '@/tests/assertions/description-list-assertion'

describe('block-page', () => {
describe('when rending a block using an invalid round number', () => {
Expand Down Expand Up @@ -71,12 +72,18 @@ describe('block-page', () => {
return executeComponentTest(
() => render(<BlockPage />, undefined, myStore),
async (component) => {
await waitFor(() => expect(getByDescriptionTerm(component.container, roundLabel).textContent).toBe(block.round.toString()))
expect(getByDescriptionTerm(component.container, timestampLabel).textContent).toBe('Thu, 29 February 2024 06:52:01')
expect(getByDescriptionTerm(component.container, transactionsLabel).textContent).toBe('0')
expect(getByDescriptionTerm(component.container, previousRoundLabel).textContent).toBe((block.round - 1).toString())
expect(getByDescriptionTerm(component.container, nextRoundLabel).textContent).toBe((block.round + 1).toString())

await waitFor(() =>
descriptionListAssertion({
container: component.container,
items: [
{ term: roundLabel, description: block.round.toString() },
{ term: timestampLabel, description: 'Thu, 29 February 2024 06:52:01' },
{ term: transactionsLabel, description: '0' },
{ term: previousRoundLabel, description: (block.round - 1).toString() },
{ term: nextRoundLabel, description: (block.round + 1).toString() },
],
})
)
const transactionsRow = getAllByRole(component.container, 'row')[1]
expect(transactionsRow.textContent).toBe('No results.')
}
Expand All @@ -101,31 +108,47 @@ describe('block-page', () => {
return executeComponentTest(
() => render(<BlockPage />, undefined, myStore),
async (component) => {
await waitFor(() => expect(getByDescriptionTerm(component.container, roundLabel).textContent).toBe(block.round.toString()))
expect(getByDescriptionTerm(component.container, timestampLabel).textContent).toBe('Thu, 29 February 2024 06:52:01')
expect(getByDescriptionTerm(component.container, transactionsLabel).textContent).toBe('2Payment=1Asset Transfer=1')
expect(getByDescriptionTerm(component.container, previousRoundLabel).textContent).toBe((block.round - 1).toString())
expect(getByDescriptionTerm(component.container, nextRoundLabel).textContent).toBe((block.round + 1).toString())
await waitFor(() =>
descriptionListAssertion({
container: component.container,
items: [
{ term: roundLabel, description: block.round.toString() },
{ term: timestampLabel, description: 'Thu, 29 February 2024 06:52:01' },
{ term: transactionsLabel, description: '2Payment=1Asset Transfer=1' },
{ term: previousRoundLabel, description: (block.round - 1).toString() },
{ term: nextRoundLabel, description: (block.round + 1).toString() },
],
})
)

const rows = getAllByRole(component.container, 'row')
expect(rows.length).toBe(3)
const transactionsRow1 = rows[1]
const row1Cells = getAllByRole(transactionsRow1, 'cell')
expect(row1Cells[0].textContent).toBe(ellipseId(transaction1.id))
expect(row1Cells[1].textContent).toBe(ellipseId(transaction1.group))
expect(row1Cells[2].textContent).toBe(ellipseAddress(transaction1.sender))
expect(row1Cells[3].textContent).toBe(ellipseAddress(transaction1['payment-transaction']!.receiver))
expect(row1Cells[4].textContent).toBe('Payment')
expect(row1Cells[5].textContent).toBe((transaction1['payment-transaction']!.amount / 1e6).toString())

const transactionsRow2 = rows[2]
const row2Cells = getAllByRole(transactionsRow2, 'cell')
expect(row2Cells[0].textContent).toBe(ellipseId(transaction2.id))
expect(row2Cells[1].textContent).toBe(ellipseId(transaction2.group))
expect(row2Cells[2].textContent).toBe(ellipseAddress(transaction2.sender))
expect(row2Cells[3].textContent).toBe(ellipseAddress(transaction2['asset-transfer-transaction']!.receiver))
expect(row2Cells[4].textContent).toBe('Asset Transfer')
expect(row2Cells[5].textContent).toBe(`${(transaction2['asset-transfer-transaction']!.amount as number) / 1e6} USDt`)
tableAssertion({
container: component.container,
rows: [
{
cells: [
ellipseId(transaction1.id),
ellipseId(transaction1.group),
ellipseAddress(transaction1.sender),
ellipseAddress(transaction1['payment-transaction']!.receiver),
'Payment',
(transaction1['payment-transaction']!.amount / 1e6).toString(),
],
},
{
cells: [
ellipseId(transaction2.id),
ellipseId(transaction2.group),
ellipseAddress(transaction2.sender),
ellipseAddress(transaction2['asset-transfer-transaction']!.receiver),
'Asset Transfer',
`${(transaction2['asset-transfer-transaction']!.amount as number) / 1e6} USDt`,
],
},
],
})
}
)
})
Expand Down
Loading
Loading