Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catchpoints: add accountsRound check against R-320 horizon values to catchpointFileWriter #6240

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cce
Copy link
Contributor

@cce cce commented Jan 29, 2025

Summary

Fix issue with onlineaccounts updateRound column for certain accounts in catchpoint files when updateRound < R-320. Renames MakeOnlineAccountsIter to MakeOrderedOnlineAccountsIter (without logic changes) so it is more clear the DB provides an ordering on (account, updround).

Test Plan

Update tests and add new ones.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 51.77%. Comparing base (e60d3dd) to head (acac925).

Files with missing lines Patch % Lines
...edger/store/trackerdb/sqlitedriver/sqlitedriver.go 0.00% 2 Missing ⚠️
cmd/catchpointdump/file.go 0.00% 1 Missing ⚠️
ledger/catchupaccessor.go 0.00% 1 Missing ⚠️
ledger/store/trackerdb/dualdriver/dualdriver.go 0.00% 1 Missing ⚠️
ledger/store/trackerdb/generickv/reader.go 0.00% 1 Missing ⚠️
ledger/store/trackerdb/sqlitedriver/kvsIter.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6240      +/-   ##
==========================================
+ Coverage   49.25%   51.77%   +2.52%     
==========================================
  Files         644      644              
  Lines       86521    86526       +5     
==========================================
+ Hits        42617    44801    +2184     
+ Misses      41040    38860    -2180     
- Partials     2864     2865       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants