Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Add TELEMETRY_URL support for telemetry configuration #6237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pbennett
Copy link

This commit introduces the TELEMETRY_URL environment variable to specify a custom endpoint for telemetry reporting when TELEMETRY_NAME is set. The README has been updated with details, and the run.sh script now handles configuring the telemetry endpoint if the variable is provided.

Summary

Nodely now offers a telemetry service for node runners, but to use, you must change the telemetry endpoint. This change adds a new env. val that can be set to override the telemetry endpoint without having to mount a custom logging.config.
Setting both TELEMETRY_NAME and TELEMETRY_URL is necessary to enable.

Test Plan

This commit introduces the TELEMETRY_URL environment variable to specify a custom endpoint for telemetry reporting when TELEMETRY_NAME is set.
The README has been updated with details, and the run.sh script now handles configuring the telemetry endpoint if the variable is provided.
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.85%. Comparing base (a81d54f) to head (667cbe6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6237      +/-   ##
==========================================
+ Coverage   51.83%   51.85%   +0.01%     
==========================================
  Files         643      643              
  Lines       86382    86382              
==========================================
+ Hits        44780    44795      +15     
+ Misses      38735    38724      -11     
+ Partials     2867     2863       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmalouf gmalouf changed the title Add TELEMETRY_URL support for telemetry configuration Config: Add TELEMETRY_URL support for telemetry configuration Jan 29, 2025
@gmalouf gmalouf marked this pull request as ready for review January 29, 2025 16:31
@gmalouf gmalouf self-requested a review January 29, 2025 16:31
@gmalouf
Copy link
Contributor

gmalouf commented Jan 29, 2025

@pbennett have you build a binary from this branch yourself with the config override?

@gmalouf gmalouf requested a review from algorandskiy January 29, 2025 16:32
@pbennett
Copy link
Author

@pbennett have you build a binary from this branch yourself with the config override?

I'd planned to but my pipelines all switched some time back to using the algorand image and it would take some work to do so. The change is so trivial though it feels pretty safe?

@pbennett
Copy link
Author

Tagging @urtho for a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants