p2p: fan in incoming txns into backlog worker #6126
+88
−70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While investigating p2p TX traffic and performance, I found transaction pool mutex congestion. This PR is a PoC to use
backlogWorker
as a pool only accessor similarly to wsnet.Implementation summary:
syncCh
channel to work itemwi
syncCh
is initiated and awaited making validation synchronous as before.backlogWorker
checks ifsyncCh
is set and responds with validation result to the channel.Additionally, there are couple more fixes that helped with TPS as well:
sub.Next()
faster.Test Plan