Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): update sample_datasets fetch url #4364

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LorrisSaintGenez
Copy link

@LorrisSaintGenez LorrisSaintGenez commented Jan 16, 2025

🧭 What and Why

🎟 JIRA Ticket: [SELFSER-969](https://algolia.atlassian.net/browse/SELFSER-969?atlOrigin=eyJpIjoiMTJiNDg3MjhiOTg3NDhjNmExMTY3YzkwYTFkN2Y0MzYiLCJwIjoiaiJ9)

We're updating the dashboard sample_datasets url on this PR.
We need to waiting until it's merged before merging this current PR

Changes included:

  • Update sample_datasets URL on all api clients

⚠️ Dependencies

https://github.com/algolia/AlgoliaWeb/pull/23286

@LorrisSaintGenez LorrisSaintGenez self-assigned this Jan 16, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 16, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@17' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 3e4860213485b925e01ea9fa1d5847699e084a91
🍃 Generated commit b6c5c98bbeb9b867f1fb0559ec012357e76d2749
🌲 Generated branch generated/feat/selfser-969
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1654
javascript 1644
php 1444
csharp 1408
java 1104
python 1053
ruby 822
swift 730

@LorrisSaintGenez LorrisSaintGenez changed the title feat(datasets): update sample_datasets fetch url feat(scripts): update sample_datasets fetch url Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants