fix(specs): recommendHit is generic #4358
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪓 The generated code will be pushed at the end of the CI.Action triggered by commit Please do not push any generated code to this pull request. |
shortcuts
reviewed
Jan 14, 2025
Comment on lines
+49
to
+52
| bundle.put("defaultGeneric", "Hit.class"); | ||
| if (this.client.equals("recommend")) { | ||
| bundle.put("defaultGeneric", "RecommendHit.class"); | ||
| } |
There was a problem hiding this comment.
should it be controlled at the spec level with something like x-defaultGeneric maybe? I guess that's rare enough to not optimize it
| } | ||
| // we don't know in which order the model will come, so we iterate multiple times to make sure | ||
| // models at any depth are propagated | ||
| for (int i = 0; i < 5; i++) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket:
Make the
RecommendHitgeneric.